fix 6074 (mod_alias failed to handle re_write config) #6892
Conversation
CT Test Results 2 files 21 suites 14m 0s ⏱️ Results for commit dcb3a32. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for contribution and fix proposal. |
|
I've rebased the PR to current maint branch, so that we can test PR. |
Fixed functionallity of re_write property. Previous code coudn't work because there was "^"++FakeName line, but FakeName could be MatchPattern so this would fail. I changed the behaviour to append "^" while storeing the re_write, alias or script_alias proplist. Also, I included one simple re_write property into test, to make sure everything works correcty.
u3s
added
bug
|
I think the PR looks good.
Such calls could be added in alias test case together with setting script_re_write option earlier: |
|
Is this what you meant? I'm not sure I understood "UNWANTED" part. Should it return 404? |
:-D. I just thought about something that is pattern matched successfully. So we have a URI towards script that is expected to pattern match and rewritten by httpd. Success HTTP code is expected as well. "UNWANTED" was supposed to be something to exercise Sorry for confusion. |
MarkoMin
force-pushed
the
inets/https/fix6074
branch
from
dcb3a32
to
042f7a9
Compare
|
I misunderstood it... "/cgi-bin/erl/..." is actually for ESI scripts, while "script_re_write" is only for CGI scripts. I've amended changes to the latest commit, take a look :D |
|
looks as I wished. I will merge it soon. |
Fixed functionallity of re_write property (Issue #6074).
Previous code coudn't work because there was "^"++FakeName line,
but FakeName could be MatchPattern so this would fail.
I changed the behaviour to append "^" while storeing the re_write, alias or script_alias proplist.
Also, I included one simple re_write property into test, to make sure everything works correcty.