erts: Support is_boolean/1 in match specs #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
CT Test Results 3 files 133 suites 49m 0s ⏱️ Results for commit 1b787560. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
force-pushed
the
john/erts/is_boolean-match-specs/GH-7045/OTP-18526
branch
from
51e9d89
to
c6a25d7
Compare
|
Can you also add the BIFs to docs at https://www.erlang.org/doc/apps/erts/match_spec.html, |
christhekeele
added a commit
to christhekeele/matcha
that referenced
this pull request
Mar 23, 2023
…rlang/otp#7046. Still issues with is_record, but that's in our macro expansion land now.
christhekeele
added a commit
to christhekeele/matcha
that referenced
this pull request
Mar 23, 2023
…rlang/otp#7046. Still issues with is_record, but that's in our macro expansion land now.
|
Just finished testing all of these with |
jhogberg
force-pushed
the
john/erts/is_boolean-match-specs/GH-7045/OTP-18526
branch
from
c6a25d7
to
1b78756
Compare
|
Thanks, I've pushed an update with fixed documentation and extended tests. :-) |
sverker
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few missing guard BIFs like
is_boolean/1to the list of functions allowed in match specifications, and adds a test to ensure that all new guard BIFs are added to this list.Fixes #7045