Make crypto run with FIPS on OpenSSL 3.0 #7392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 14 suites 7m 7s ⏱️ Results for commit 830ce7a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Added some tweaking of tests to please FIPS. |
sverker
force-pushed
the
sverker/crypto/fips-openssl3.0
branch
2 times, most recently
from
6cb003c
to
701e5d8
Compare
|
All crypto tests pass on OpenSSL 3.0.9 and 3.1.1 with FIPS. |
This was referenced Jun 20, 2023
Closed
to prepare for using FIPS on OpenSSL 3.0
It is not allowed to write to the binary buffer returned by enif_inspect_binary() (even if you created the binary yourself). In DEBUG built VM such abuse will be punished with: "Readonly data written by NIF, checksums differ 8000425 != 25040008 ABORTING" Instead use enif_make_new_binary() to create a writable binary buffer.
OpenSSL 3 FIPS does only accept named ec curves. So we try that first, and if it fails we retry with the params passed down by crypto.erl.
to pass OpenSSL the name it accepts.
FIPs on OpenSSL 3 seems to demand P to be a safe prime where Q = (P-1)/2 is also prime.
sverker
force-pushed
the
sverker/crypto/fips-openssl3.0
branch
from
830ce7a
to
bb6e559
Compare
|
Merged to maint for release in OTP-26.1. The branch is based on OTP-25.3.2, but will probably not be release in any 25.3.2.* release as it's more than a bug fix. |
|
Thank you from Team RabbitMQ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7086
Fix #6981
Fix #6566
Fix #6406