ssl: Remove compression handling #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 66 suites 48m 58s ⏱️ For more details on these failures, see this check. Results for commit 86bab0f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
requested changes
Jun 28, 2023
dgud
force-pushed
the
dgud/ssl/remove-compression/OTP-18665
branch
from
4c9a56c
to
93ef79d
Compare
u3s
approved these changes
Jun 29, 2023
IngelaAndin
approved these changes
Jul 10, 2023
Compress is deprecated and deemed unsecure so we will never implement it, remove all handling of it to save memory and performance.
dgud
force-pushed
the
dgud/ssl/remove-compression/OTP-18665
branch
from
86bab0f
to
7dcca29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compression is deprecated and deemed unsecure so we will never implement it,
remove all handling of it to save memory and performance.