crypto: Fix segv crash after purge and reload of crypto on musl libc #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symptom: Different kind of segv crashes after crypto is loaded, purged and loaded again. Problem: dlclose on musl libc is a no-op. Mutex 'mtx_init_curve_types' was destroyed at unload and then not re-created at reload as static variable `library_initialized` in crypto.c is true because musl dlclose is a no-op and dlopen reuses the existing loaded crypto.so library with static variables intact.
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/5402652644 Results for commit fae85c2 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7436
Symptom: Different kind of segv crashes seen after crypto is loaded, purged and loaded again.
Problem:
dlclose on musl libc is a no-op.
Mutex 'mtx_init_curve_types' was destroyed by unload (called at module purge) and then not re-created at reload as static variable
library_initializedin crypto.c was true because musl dlclose is a no-op and dlopen reuses the existing loaded crypto.so library with static variables intact.