inets: httpd avoid function_clause during startup #7513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Jul 26, 2023
u3s
commented
- avoid function_clause httpd_request:body_data/2
- happening when httpd is stopped during TLS negotiation
- in such cases Manager process is killed and then continue_init fails
- avoid function_clause httpd_request:body_data/2 - happening when httpd is stopped during TLS negotiation - in such cases Manager process is killed and then continue_init fails
u3s
force-pushed
the
kuba/inets/httpd_function_clause/OTP-18688
branch
from
074c707
to
245b210
Compare
| case Result of | ||
| error -> | ||
| httpd_util:error_log(ConfigDB, | ||
| httpd_logger:error_report('TLS', Status, |
There was a problem hiding this comment.
It is not known at this point that it is a 'TLS' socket. The other atom used in this module, in this argument position would be internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.