Fix crash when compiling is_list/1 call #7518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
CT Test Results 2 files 296 suites 13m 19s ⏱️ Results for commit f9a3fa9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
bjorng
force-pushed
the
bjorn/compiler/fix-is_list-crash/GH-7504/OTP-18689
branch
from
2764673
to
7f94589
Compare
bjorng
force-pushed
the
bjorn/compiler/fix-is_list-crash/GH-7504/OTP-18689
branch
from
7f94589
to
f9a3fa9
Compare
jhogberg
approved these changes
Jul 31, 2023
Comment on lines
+1280
to
+1284
| %% This instruction was a call to is_list/1, which was | ||
| %% rewritten to an is_nonempty_list test by | ||
| %% beam_ssa_type. BEAM has no is_nonempty_list instruction | ||
| %% that will return a boolean, so we must revert it to an | ||
| %% is_list/1 call. |
There was a problem hiding this comment.
Given the relative rarity of needing boolean values from type tests, I wonder if it wouldn't be better to convert them at an early stage from A = is_xyz(X) to something like A = if is_xyz(X) -> true; not is_xyz(X) -> false end (it would also simplify some of the work I'm doing 😄).
bjorng
deleted the
bjorn/compiler/fix-is_list-crash/GH-7504/OTP-18689
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7504