Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: update the keymap configuration interface #7647

Conversation

frazze-jobb
Copy link
Contributor

Changes the interface for updating the keymap configuration in the shell so that it is configurable via kernel app config parameter.

@frazze-jobb frazze-jobb added team:VM Assigned to OTP team VM fix documentation labels Sep 11, 2023
@frazze-jobb frazze-jobb self-assigned this Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

CT Test Results

       5 files     272 suites   2h 25m 6s ⏱️
4 704 tests 4 367 ✔️ 336 💤 1
5 753 runs  5 343 ✔️ 409 💤 1

For more details on these failures, see this check.

Results for commit 26a5207.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are exposing the edlin module I think we should add a function to it to fetch the current keymap.

Also the keymap configuration parameter should be in the stdlib application as there is where most of the parameters for the shell are located.

The keymap key should also be listed in Stdlib and should probably be called "shell_keymap" for consistency.

I assume the tty documentation also needs some updates?

And also shell should probably mention that it is possible to configure the keymap?

lib/stdlib/doc/src/edlin.xml Outdated Show resolved Hide resolved
Changes the interface for updating the keymap configuration in the shell
so that it is configurable via kernel app config parameter.
@frazze-jobb frazze-jobb force-pushed the frazze/stdlib/keyboard_config_interface_change branch from 7f34a38 to 319b932 Compare September 11, 2023 21:04
Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an entry in edlin.xml for the new function, but besides that this looks good to me.

@frazze-jobb frazze-jobb force-pushed the frazze/stdlib/keyboard_config_interface_change branch from 077cb51 to a0c26db Compare September 14, 2023 11:16
Co-authored-by: Lukas Larsson <garazdawi@gmail.com>
Co-authored-by: Lukas Larsson <garazdawi@gmail.com>
@frazze-jobb frazze-jobb merged commit 978ee4d into erlang:maint Sep 18, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation fix team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants