Skip beam_ssa_alias for modules with huge functions #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
CT Test Results 2 files 296 suites 12m 14s ⏱️ Results for commit 4d7939b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
The implementation of the `beam_ssa_alias` pass in OTP 26 can become extremly slow for modules containing huge functions. The `master` branch (for the OTP 27 release next year) already contains a much better implementation that handles huge functions. That implementation is also very different, so we don't want to back-port it to OTP 26. To make the compiler in OTP 26 usable for huge functions, add a heuristic that disables the alias analysis pass for functions exceeding a certain number of blocks. Fixes erlang#7667
bjorng
force-pushed
the
bjorn/compiler/fix-alias-pass/GH-7667/OTP-18770
branch
from
1edb471
to
4d7939b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the
beam_ssa_aliaspass in OTP 26 can become extremly slow for modules containing huge functions. Themasterbranch (for the OTP 27 release next year) already contains a much better implementation that handles huge functions. That implementation is also very different, so we don't want to back-port it to OTP 26.To make the compiler in OTP 26 usable for huge functions, add a heuristic that disables the alias analysis pass for functions exceeding a certain number of blocks.
Fixes #7667