Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEP 66: Sigils for String Literals #7684

Merged
merged 5 commits into from Nov 10, 2023
Merged

EEP 66: Sigils for String Literals #7684

merged 5 commits into from Nov 10, 2023

Conversation

RaimoNiskanen
Copy link
Contributor

@RaimoNiskanen RaimoNiskanen commented Sep 26, 2023 •
edited

A draft for handling Elixir-like Sigils for String Literals as suggested in EEP PR-53

@RaimoNiskanen RaimoNiskanen self-assigned this Sep 26, 2023
@RaimoNiskanen RaimoNiskanen marked this pull request as draft September 26, 2023 15:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit 29ac2fc

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Sep 27, 2023
@RaimoNiskanen RaimoNiskanen changed the title EEP 65?: Sigils for String Literals EEP 66?: Sigils for String Literals Sep 29, 2023
@RaimoNiskanen RaimoNiskanen force-pushed the raimo/lang-dev branch 2 times, most recently from 5db2545 to 98522cb Compare October 6, 2023 14:08
@RaimoNiskanen RaimoNiskanen marked this pull request as ready for review October 6, 2023 14:08
@RaimoNiskanen
Copy link
Contributor Author

Now implements ~, ~r, ~S and ~C sigils, according to PR erlang/eep#53.
Test cases are missing.
Module re integration is not done.
Maybe ~s and ~c sigils should be added.

@RaimoNiskanen
Copy link
Contributor Author

I have sketched on naïve module re integration.
Sigils ~s and c are now implemented, without any interpolation.

@RaimoNiskanen RaimoNiskanen force-pushed the raimo/lang-dev branch 2 times, most recently from 2576125 to 421b529 Compare October 12, 2023 16:28
@RaimoNiskanen
Copy link
Contributor Author

Rebased, and reverted to full set of delimiters

@RaimoNiskanen
Copy link
Contributor Author

Now with documentation

@RaimoNiskanen RaimoNiskanen force-pushed the raimo/lang-dev branch 2 times, most recently from cfb61b4 to 6788ec9 Compare October 27, 2023 10:41
@RaimoNiskanen RaimoNiskanen changed the title EEP 66?: Sigils for String Literals EEP 66: Sigils for String Literals Nov 7, 2023
@RaimoNiskanen
Copy link
Contributor Author

Rebased away the early development messiness

@RaimoNiskanen RaimoNiskanen merged commit f8337ee into erlang:master Nov 10, 2023
11 of 16 checks passed
@RaimoNiskanen RaimoNiskanen deleted the raimo/lang-dev branch November 10, 2023 10:24
@IngelaAndin IngelaAndin added the Planned Focus issue added in sprint planning label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorng bjorng Awaiting requested review from bjorng

@kikofernandez kikofernandez Awaiting requested review from kikofernandez

@jhogberg jhogberg Awaiting requested review from jhogberg

Assignees

@RaimoNiskanen RaimoNiskanen

Labels
feature in progress Planned Focus issue added in sprint planning priority:medium team:PS Assigned to OTP team PS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaimoNiskanen @IngelaAndin