Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inets: add missing mime_type functionality to httpd #7843

Merged
merged 2 commits into from Dec 4, 2023

Conversation

erikareads
Copy link
Contributor

Code to address #7827.

This commit contains code to patch the issue by implementing the mime_type option, with the default_type as a fallback.

I've locally verified that this patch compiles and doesn't break existing tests,
But I'm unfamiliar with the Common Test framework for Erlang,
So I haven't yet written any automated tests.

If someone would like to contribute automated tests to this pull request,
Please do so, otherwise I will attempt to write some tests myself in the coming week.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

CT Test Results

    2 files    21 suites   11m 45s ⏱️
340 tests 335 ✔️   5 💤 0
607 runs  556 ✔️ 51 💤 0

Results for commit d5f1df8.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Nov 9, 2023
@garazdawi
Copy link
Contributor

The github actions failure are due to errors in the github scripts that should now be fixed. Please rebase your branch to latest maint and they should be solved. Thanks.

@IngelaAndin
Copy link
Contributor

@erikareads your rebased branch should not include others commits. If you update your repo to include the latest maint and then checkout your branch and do:

git rebase --onto maint HEAD~1
Where ~1 means your (one) commit it should become correct.

@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Nov 13, 2023
@IngelaAndin IngelaAndin self-assigned this Nov 13, 2023
@IngelaAndin
Copy link
Contributor

@erikareads looks good so far. You could update httpd_SUITE with a test case for the mime_type option. Look at the function server_config that you can use to make a new custom config for your test case.

@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label Nov 14, 2023
@u3s u3s linked an issue Nov 21, 2023 that may be closed by this pull request
@IngelaAndin
Copy link
Contributor

ping @erikareads do you need more help for test case creation?

@erikareads
Copy link
Contributor Author

@IngelaAndin I didn't have time to focus on this today.
Thanks for pointing me to httpd_SUITE and server_config.

@IngelaAndin IngelaAndin removed the waiting waiting for changes/input from author label Nov 29, 2023
@IngelaAndin IngelaAndin merged commit 35749ab into erlang:maint Dec 4, 2023
16 checks passed
@IngelaAndin
Copy link
Contributor

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inets:httpd mime_type property does nothing.
4 participants