erts: Share external funs globally #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
force-pushed
the
john/erts/share-external-funs
branch
from
70ffd43
to
e07698d
Compare
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit 8d053b0 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
jhogberg
force-pushed
the
john/erts/share-external-funs
branch
2 times, most recently
from
53bdd5d
to
5335501
Compare
bjorng
approved these changes
Nov 22, 2023
jhogberg
added
the
testing
|
When are these literal funs garbage collected? When the export entry that they point to is deleted? |
They have the same lifetime as their respective export entry, which are never deleted at the moment. |
By storing external funs in a dedicated literal area shared by all modules and keeping a reference to them in the export entry they refer to, they will no longer be tied to the lifetime of the module that created them. `make_fun/3` will also use this reference so that dynamic creation of an external fun will also result in a literal. Like all other literal optimizations at the moment, this will be lost when the term is placed into an ordinary ETS table (although compressed retains it by happenstance), but that is a general issue for all literals which may be fixed in a later PR.
jhogberg
force-pushed
the
john/erts/share-external-funs
branch
from
cdea7ce
to
8d053b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing external funs in a dedicated literal area shared by all modules and keeping a reference to them in the export entry they refer to, they will no longer be tied to the lifetime of the module that created them.
make_fun/3will also use this reference so that dynamic creation of an external fun also results in a shared literal. This opens up for optimizations in, for example,gen_statemwhere there will no longer be any drawbacks to caching the event function when instate_functionsmode.