ssl: Get dhfile ssl option #7984
Conversation
CT Test Results 2 files 66 suites 47m 29s ⏱️ Results for commit 4727af1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
added
testing
|
@avtobiff You need to also list the test case in "the test case listing". The test function listing in simple_api_tests/0 would be a good place for this test suite. |
The fallback after "dh" ssl option was undefined was to get "dh" from ssl options again. This is clearly wrong and now changed to the documented fallback "dhfile" ssl option. Add test for passing an invalid dhparams file to server ssl options. Signed-off-by: Per Andersson <avtobiff@foo.nu>
avtobiff
force-pushed
the
ssl/invalid-dhfile
branch
from
b66f0e6
to
4727af1
Compare
|
@IngelaAndin Added it to simple_api_tests/0 as you suggested. |
IngelaAndin
added
testing
|
@avtobiff Great then the test case will actually be run now. Need to wait for the test to be run in our builds before we can merge. |
|
Thanks for the PR |
The fallback after "dh" ssl option was undefined was to get "dh" from
ssl options again. This is clearly wrong and now changed to the
documented fallback "dhfile" ssl option.
Add test for passing an invalid dhparams file to server ssl options.