Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Add brainpool for TLS-1.3 #8056

Merged

Conversation

IngelaAndin
Copy link
Contributor

@IngelaAndin IngelaAndin commented Jan 26, 2024

Add support brainpool elliptic curves in TLS-1.3

@IngelaAndin IngelaAndin self-assigned this Jan 26, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

CT Test Results

    2 files     67 suites   48m 20s ⏱️
  787 tests   743 ✅  44 💤 0 ❌
3 758 runs  2 964 ✅ 794 💤 0 ❌

Results for commit 6801f0f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch 4 times, most recently from 74250ef to 84bbf7c Compare January 31, 2024 14:10
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Jan 31, 2024
@u3s u3s removed the testing currently being tested, tag is used by OTP internal CI label Jan 31, 2024
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Feb 2, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch from 84bbf7c to 7b706ab Compare February 12, 2024 09:54
@IngelaAndin IngelaAndin removed the testing currently being tested, tag is used by OTP internal CI label Feb 12, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch from 7b706ab to 9991bd2 Compare February 12, 2024 12:32
@IngelaAndin IngelaAndin requested review from dgud and u3s February 12, 2024 12:36
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch from 9991bd2 to f3dc225 Compare February 12, 2024 13:03
lib/ssl/src/ssl.erl Outdated Show resolved Hide resolved
lib/ssl/src/ssl.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch from f3dc225 to 20ab762 Compare February 12, 2024 20:07
lib/ssl/src/ssl.erl Outdated Show resolved Hide resolved
@IngelaAndin
Copy link
Contributor Author

I think the strongest argument for deprecating prf, is that it is confusing in many ways for the user. It has legacy name that most people do not understand. It has confusing arguments that can fool you into using something that does not fulfill exporter guarantees. SSL/TLS is hard enough without these sources of confusion.

@IngelaAndin
Copy link
Contributor Author

I will redo this when #8169 has been merged. Maybe we can keep ecc function with new doc and not document ec_curves.

@IngelaAndin IngelaAndin added the stalled waiting for input by the Erlang/OTP team label Mar 5, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch 3 times, most recently from 9ab3699 to fcf74f4 Compare March 6, 2024 15:43
@IngelaAndin IngelaAndin added testing currently being tested, tag is used by OTP internal CI and removed stalled waiting for input by the Erlang/OTP team labels Mar 6, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch 3 times, most recently from 8e232ff to d2ba738 Compare March 8, 2024 10:42
Also fix eccs documentation in markdown (patched in OTP-26 after conversion)
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/brainpool-TLS-1.3/OTP-18884 branch from d2ba738 to 6801f0f Compare March 8, 2024 10:46
@IngelaAndin IngelaAndin merged commit c743e1c into erlang:master Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants