Handle asn1 decode errors #8256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 67 suites 50m 21s ⏱️ Results for commit 2c80725. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
dgud
force-pushed
the
dgud/ssl/catch_asn1_decoding_error/GH-8058/OTP-18969
branch
3 times, most recently
from
93e5606
to
2c80725
Compare
IngelaAndin
reviewed
Mar 13, 2024
lib/ssl/src/ssl_handshake.erl
Outdated
| @@ -353,8 +353,9 @@ certify(#certificate{asn1_certificates = ASN1Certs}, CertDbHandle, CertDbRef, | |||
| path_validation_alert(Reason) | |||
| end | |||
| catch | |||
| error:{_,{error, {asn1, Asn1Reason}}} -> | |||
| error:{_,{error, {asn1, Asn1Reason}}}=OtherReason:ST -> | |||
There was a problem hiding this comment.
So when we get here we no longer decode any certificates here and this error clause should no be dead code!
u3s
approved these changes
Mar 14, 2024
Asn.1 errors was not handled in all places, catch the decoding of the DerCerts. Also while at it change usage to handle 'combined_cert()' to only decode the certs once, improves performance.
dgud
force-pushed
the
dgud/ssl/catch_asn1_decoding_error/GH-8058/OTP-18969
branch
from
2c80725
to
ba2403c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asn.1 errors was not handled in all places, catch the decoding of the DerCerts.
Also while at it change usage to handle 'combined_cert()' to only decode the certs once, improves performance.
Fixes #8058