crypto: Remove incorrect configure check for FIPS_mode_set #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 14 suites 6m 19s ⏱️ Results for commit 41bcb7f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
* FIPS_mode_set does not exists since OpenSSL 3.x * The AC_CHECK_FUNC for FIPS_mode_set succeeds anyway on Linux as compiler accepts implicit declaration (with only a warning) and linker accepts undefined symbols as we build a shared lib. On MacOS however, the check "works" and thereby hinders building Erlang/OTP with --enabled-fips for OpenSSL 3.x.
sverker
force-pushed
the
sverker/crypto/fips-config-mac
branch
from
e0d2d35
to
41bcb7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8271
FIPS_mode_setdoes not exists since OpenSSL 3.xThe configure check with
AC_CHECK_FUNCforFIPS_mode_setsucceeds anyway on Linux as compiler accepts implicit declaration (with only a warning) and linker accepts undefined symbols as we build a shared lib.Checking for
FIPS_mode_setwas pointless as it was available even for non-fips builds of OpenSSL 1.xOn MacOS however, the check "works" and thereby hinders building Erlang/OTP with
--enabled-fipsfor OpenSSL 3.x.