inet_res: relax RD flag query/response check
#8312
Conversation
CT Test Results 2 files 67 suites 1h 2m 44s ⏱️ Results for commit 604f28b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
RaimoNiskanen
force-pushed
the
fix_inet_res_rd
branch
from
04c27f0
to
604f28b
Compare
|
Looks just fine. I might have preferred a more traditional style for the guard check, but don't think it is worth the change, I have rebased to target this for the next patch on OTP-26. |
|
The PR is now merged to 'maint' and 'master', and in the pipeline for OTP-26.2.4 ('maint-26'). I hope this PR and the linked Issue will auto close when that is release, if not I will have to step in... Thank you for your contribution! |
You're welcome :) |
Fixes #8303, as suggested by @Maria-12648430.
Section 3.1.3 of RFC 8906 suggests that DNS servers that do not understand a flag should not copy it to the response. Further, section 3.1.3.1 suggests that non-recursive servers should respond as if the RD flag was not set.