Scheduler specific data fix and improved monotonic time checks #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…43/OTP-19044' into rickard/sched-spec-data-fix/os-monotonic-fix/25/OTP-19043/OTP-19044 * rickard/sched-spec-data-fix/os-monotonic-fix/24/OTP-19043/OTP-19044: [erts] configure option for ensuring monotonicity of OS monotonic time [erts] Improve checking of monotonic time [erts] Replace potential harmful uses of erts_proc_sched_data()
…43/OTP-19044' into rickard/sched-spec-data-fix/os-monotonic-fix/26/OTP-19043/OTP-19044 * rickard/sched-spec-data-fix/os-monotonic-fix/25/OTP-19043/OTP-19044: [erts] configure option for ensuring monotonicity of OS monotonic time [erts] Improve checking of monotonic time [erts] Replace potential harmful uses of erts_proc_sched_data()
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit f68cd58 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP-19043
When a traced process executing on a dirty scheduler received an exit signal, the dirty scheduler could use the wrong thread specific data which could lead to a crash.
OTP-19044
Checks for monotonicity of monotonic time have been improved so that Erlang and OS monotonic time are checked separately.
A new
configureargument--enable-ensure-os-monotonic-timehas also been added. It enables functionality ensuring the monotonicity of monotonic timestamps delivered by the OS. When a non-monotonic timestamp is detected, it will be replaced by the last delivered monotonic timestamp before being used by Erlang's time functionality. Note that you do not want to enable this unless the OS monotonic time source on the system fails to produce monotonic timestamps. This since ensuring the monotonicity of OS monotonic timestamps will hurt scalability and performance of the system.