ssl: Fix cert_auth check #8367
Merged
ssl: Fix cert_auth check #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 66 suites 47m 6s ⏱️ Results for commit a2c9913. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
force-pushed
the
ingela/ssl/cert_auth/GH-8356/OTP-19065
branch
2 times, most recently
from
a0c0530
to
59489fc
Compare
wattsnicky89
approved these changes
Apr 12, 2024
IngelaAndin
force-pushed
the
ingela/ssl/cert_auth/GH-8356/OTP-19065
branch
from
59489fc
to
0823551
Compare
IngelaAndin
added
the
testing
samfrench
reviewed
Apr 16, 2024
lib/ssl/test/ssl_cert_SUITE.erl
Outdated
| @@ -981,6 +984,25 @@ key_auth_ext_sign_only(Config) when is_list(Config) -> | |||
| ssl_test_lib:basic_test(ClientOpts, ServerOpts, Config). | |||
|
|
|||
| %%-------------------------------------------------------------------- | |||
| cert_auth_in_first_ca() -> | |||
| [{doc,"Test cert auth will be available in firs ca in chain, make it happen by only having one"}]. | |||
There was a problem hiding this comment.
@IngelaAndin, thank you for fixing this for us. A minor comment about a typo in the test description for "first".
There was a problem hiding this comment.
Thanks for noticing, fixed.
Include also end entity cert when selecting issuers for cert_auth extension check Closes erlang#8356
IngelaAndin
force-pushed
the
ingela/ssl/cert_auth/GH-8356/OTP-19065
branch
from
0823551
to
a2c9913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include also end entity cert when selecting issuers for cert_auth extension check
Closes #8356