Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erts: Fix calculate_cpu_quota #8380

Merged

Conversation

garazdawi
Copy link
Contributor

#8259 has swicthed the order of argument for cpu quota calculations causing it to always calculate 1 as the quota.

We really should figure out a way to test this....

@garazdawi garazdawi added team:VM Assigned to OTP team VM fix labels Apr 15, 2024
@garazdawi garazdawi requested a review from jhogberg April 15, 2024 08:37
@garazdawi garazdawi self-assigned this Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

CT Test Results

    3 files    143 suites   49m 56s ⏱️
1 587 tests 1 538 ✅ 49 💤 0 ❌
2 326 runs  2 252 ✅ 74 💤 0 ❌

Results for commit a381114.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@garazdawi garazdawi force-pushed the lukas/erts/fix-cpu-quota-calculation branch from 6ba413e to ed04b2f Compare April 15, 2024 09:06
PR erlang#8259 has swicthed the order of argument for
cpu quota calculations causing it to always
calculate 1 as the quota.
@garazdawi garazdawi force-pushed the lukas/erts/fix-cpu-quota-calculation branch from ed04b2f to a381114 Compare April 15, 2024 09:18
@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Apr 18, 2024
@garazdawi garazdawi merged commit 21b0df5 into erlang:master Apr 19, 2024
17 checks passed
@garazdawi garazdawi deleted the lukas/erts/fix-cpu-quota-calculation branch April 19, 2024 10:45
@garazdawi garazdawi added this to the OTP-26.2.5 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant