Fix potential deadlock during system shutdown #8422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 72 suites 1h 5m 49s ⏱️ Results for commit 172a15c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/kernel/fix-application-shutdown-deadlock/OTP-19078
branch
from
88d77ed
to
6d77192
Compare
There used to be a bug where the AC would block and set_env would crash. This caused the shell to be unuseable as it crashed all the time. So we add some safe guards to make sure that does not happen again.
garazdawi
force-pushed
the
lukas/kernel/fix-application-shutdown-deadlock/OTP-19078
branch
from
81d757b
to
172a15c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a process in an application calls any blocking
applicationAPI call with infinite timeout and is trapping exits, there is a risk that it will deadlock the shutdown of the node. So we update application_controller to respond to calls while terminating so that the caller will crash and the system can be shutdown as it should.