Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mnesia doc after new doc system #8426

Merged
merged 1 commit into from Apr 29, 2024
Merged

Conversation

dgud
Copy link
Contributor

@dgud dgud commented Apr 26, 2024

No description provided.

@dgud dgud requested a review from IngelaAndin April 26, 2024 09:07
@dgud dgud self-assigned this Apr 26, 2024
@dgud dgud added team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI documentation labels Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

CT Test Results

  2 files   55 suites   19m 8s ⏱️
675 tests 528 ✅ 147 💤 0 ❌
728 runs  567 ✅ 161 💤 0 ❌

Results for commit 67723b5.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin
Copy link
Contributor

@dgud I think your changes are enhancements. My comments are mainly for what you did not change.

This description "A distributed telecommunications DBMS" feels strange, should we not have a more general description.
as maybe a "key-value DBMS", this formulation kind of suggest that it is only useful for telecommunications! I also think we should explain the abbreviation at least once.

I think it looks strange in the summary that the types does not have any explanation. Some types are fairly self explaining, but some place it could be quite helpful to understand when these are applicable. However, looking at current state of the documentation elsewhere I can not find a consistent way of having or not having an explanation.

@dgud dgud merged commit 599fca3 into erlang:master Apr 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants