Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Support check should check minimum support #8504

Merged

Conversation

IngelaAndin
Copy link
Contributor

Will make TLS-1.3 work with fips

@IngelaAndin IngelaAndin self-assigned this May 23, 2024
@IngelaAndin IngelaAndin requested review from dgud and u3s May 23, 2024 14:52
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label May 23, 2024
Copy link
Contributor

github-actions bot commented May 23, 2024

CT Test Results

    2 files     67 suites   49m 30s ⏱️
  789 tests   745 ✅  44 💤 0 ❌
3 756 runs  2 962 ✅ 794 💤 0 ❌

Results for commit 3feda33.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9 4.725 tls_record.erl:422:5: syntax error before: lists
#9 4.725 % 422| lists:all(Fun, L);
#9 4.725 % | ^

@IngelaAndin IngelaAndin force-pushed the ingela/ssl-fips-minimum-check/OTP-19094 branch from e43ea5e to f64a095 Compare May 24, 2024 11:50
@IngelaAndin
Copy link
Contributor Author

@u3s humm forgot to commit last changes should be fixed now.

@IngelaAndin IngelaAndin requested a review from u3s May 24, 2024 12:54
@IngelaAndin
Copy link
Contributor Author

There seems to test case issues probably as test wants to check for more than minimal algorithms, will look into it next week.

@IngelaAndin IngelaAndin force-pushed the ingela/ssl-fips-minimum-check/OTP-19094 branch from f64a095 to 412bff5 Compare May 28, 2024 10:15
@IngelaAndin IngelaAndin reopened this May 28, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl-fips-minimum-check/OTP-19094 branch from d4d25ab to 5ccf64e Compare May 28, 2024 11:36
lib/ssl/src/tls_record.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label May 29, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl-fips-minimum-check/OTP-19094 branch from 5ccf64e to 3feda33 Compare May 30, 2024 07:36
@IngelaAndin IngelaAndin merged commit b4204c4 into erlang:maint May 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants