Customization in aws_request(xml) and erlcloud_mon #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! The only minor thing which I'd like to be fixed is to avoid shortening "protocol" to "prot", since it's it can be too easily confused with "port". If you fix it I'll merge it right away :) |
gleber
added a commit
that referenced
this pull request
Oct 30, 2012
Customization in aws_request(xml) and erlcloud_mon
|
Thank you for the contribution! |
nalundgaard
pushed a commit
to nalundgaard/erlcloud
that referenced
this pull request
Jul 29, 2015
Fix s3 non-default region usage.
egobrain
pushed a commit
to egobrain/erlcloud
that referenced
this pull request
Nov 7, 2018
Fixed ResponseBody @SPEC for request/6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customization in aws_request(aws_request_xml) and tests for it. In erlcloud_mon now can define protocol, host, port in config for put_metric_data