Make use of jsx compatibe with 3.x #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[jsx](https://github.com/talentdeficit/jsx) moved to [v3.0.0](https://github.com/talentdeficit/jsx/releases/tag/v3.0.0) on Friday, 26 June 2020. See [jsx#139](talentdeficit/jsx#139). The big change is that the default option is that `return_maps` now defaults to `true`, meaning that you will get maps output **unless** you explicitly pass `[{return_maps, false}]` when decoding JSON. This change updates internal use of jsx to *always* pass `return_maps` explicitly, true or false, so that it is compatible with jsx [v3.0.0](https://github.com/talentdeficit/jsx/releases/tag/v3.0.0). I also updated the pin of jsx to [v2.11.0](https://github.com/talentdeficit/jsx/releases/tag/v2.11.0), since I don't want to force 3.x onto clients just yet.
motobob
approved these changes
Jun 29, 2020
|
I found one use of |
|
@paulo-ferraz-oliveira looks like I missed it in the later #654. Will PR a fix. Thanks. |
nalundgaard
added a commit
that referenced
this pull request
Nov 13, 2020
Follow up to #645. I missed that I didn't catch this regression when `erlcloud_sm` was introduced in #654. This change just adds the eplicit `[{return_maps, false}]` option to the `jsx:decode(...)` call to ensure that it comes back in the expected format, regardless of which jsx version the client uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsx moved to v3.0.0 on Friday, 26 June 2020. See jsx#139. The big change is that the default option is that
return_mapsnow defaults totrue, meaning that you will get maps output unless you explicitly pass[{return_maps, false}]when decoding JSON.This change updates internal use of jsx to always pass
return_mapsexplicitly, true or false, so that it is compatible with jsx v3.0.0. I also updated the pin of jsx to v2.11.0, since I don't want to force 3.x onto clients just yet.