Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs to the actual expected values. #71

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

NAR
Copy link
Contributor

@NAR NAR commented Oct 29, 2020

The code in finalize_and_stop actually expects {save_state, State} or {ok, State}, so let's specify that in the specs.

@tsloughter
Copy link
Collaborator

Thanks!

But hm, I don't see this function actually used anywhere.. maybe its an artifact from past versions

@NAR
Copy link
Contributor Author

NAR commented Oct 30, 2020

The deactivate is called from

case erleans_utils:fun_or_default(CbModule, deactivate, 1, [CbData], {ok, CbData}) of
finalize_and_stop is called from terminate at
_ = finalize_and_stop(Data),

terminate is called when the grain stops.

@tsloughter
Copy link
Collaborator

Oh, derp! Thanks, shows how long it has been since I've looked used this code :(

@tsloughter tsloughter merged commit 7eaf7e8 into erleans:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants