-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI OTP 24 #229
CI OTP 24 #229
Conversation
@@ -23,6 +23,14 @@ | |||
]} | |||
]}. | |||
|
|||
{dialyzer, [ | |||
{warnings, [ | |||
error_handling, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if we want unhandled_returns
. unknown
is usually not friendly to rebar3
plugins.
@@ -21,5 +21,5 @@ format_error({Cmd, missing_required_params}) -> | |||
io_lib:format("Required parameters for the ~ts command have not been supplied.", [Cmd]); | |||
|
|||
format_error(Reason) -> | |||
rebar_api:debug("Unknown error : ~ts", [Reason]), | |||
rebar_api:debug("Unknown error : ~ps", [Reason]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would throw when the error is e.g. a tuple. (it was not dialyzer
, but testing on an invalid repo.)
@@ -208,7 +208,7 @@ generate_all_keys(Username, Password, LocalPassword, Repo, State) -> | |||
|
|||
%% write key | |||
WriteKeyName = api_key_name(), | |||
WritePermissions = [#{<<"domain">> => <<"api">>}], | |||
WritePermissions = [#{domain => api}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from hex_core
's API. I'm pretty sure it works in both forms, but, as-is, it's converted later, via term_to_binary
eventually (if I correctly followed the 🐰 hole).
Following #232, this has been rebased on top of |
hexpm/hex_core#121 was merged and tagged, so I pushed a remade |
jelly-beam/verl#21 was merged and tagged, so I pushed a remade |
I also fixed coverage stuff. It was hidden by the fact it didn't show an error. |
Can't actually remember why I wanted/needed to introduce
dialyzer
here, but it was somehow on my TODO list.The proposed changes only work with a yet unreleased
hex_core
which also causeddialyzer
warnings, but is a good preview of what's to come.Here it is:
Opening as draft for the above mentioned reasons.
Commenting on the stuff that might not be so obvious (or on which I have doubts).