Add include_files and exclude_files options #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`include_files` are included in addition to what's specified in `files` (or the default set of files). `exclude_files` are expanded and removed from the set of files to publish after `include_files` have been included.
|
I saw you move @tsloughter :-) Do you have any comments on this one? I could add some eunit tests or try some alternative implementations if that would help. |
|
Oh right, let me look at the code again to be sure and then i'll merge. |
|
Looks good. Sadly I can't expect tests for anything since I never added tests for anything else yet :). I'll need to do that some day so that testing isn't just expected by the end user, hehe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @benoitc 's suggestion in #26. If erlcloud/erlcloud#270 is merged to supply a
mix.exsfile theninclude_fileswould be nice to have.include_filesare included in addition to what's specified infiles(or the default set of files).
exclude_filesare expanded and removed from theset of files to publish after
include_fileshave been included.