Ease Elixir escripts execution by adding ${HOME}/.mix/escripts to path #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @btkostner. Thanks for this. I'm wondering if this is sufficiently generic though, to have included in the action. What do you think, @starbelly, @ericmj, @wojtekmach? |
|
+1 from me.
|
|
@btkostner, could you add a simple test that demonstrates the behaviour, and can be constantly used for regression testing? |
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
|
Alright, I added it to the existing install test matrix, but if you want me to split it off to it's own job, I can do that. Tests show it working in Linux and Windows. Let me know if there is more that I should do. |
paulo-ferraz-oliveira
approved these changes
Nov 22, 2022
paulo-ferraz-oliveira
changed the title
|
Merging to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the mix escripts folder to
PATH, allowing you to runmix escript.install hex protobuf --forceand have access to the protobuf generator right away. Making life simpler.I'm having this as a WIP because I don't program in windows and need to confirm this actually works as intended.