Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Erlang/OTP 26 + Elixir 1.14 on top Windows #191

Merged
merged 5 commits into from
Jun 24, 2023
Merged

Test Erlang/OTP 26 + Elixir 1.14 on top Windows #191

merged 5 commits into from
Jun 24, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Apr 28, 2023

Let's keep this open until building OTP 26 on Windows is possible.

This seems to be in a mergeable state, now. Just need to make sure CI is issue-less.(1)

Hopefully fixes #189.


(1) Yeah, there's some confusion with master v. main but I'll change everything to main.

@paulo-ferraz-oliveira paulo-ferraz-oliveira added the help wanted Extra attention is needed label May 8, 2023
@aboroska
Copy link

Can we add 26.0 on Ubuntu to the mix?

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Add Erlang/OTP 26.0-rc3 to the mix Have Erlang/OTP 26 + Elixir 1.14 be usable in Windows May 17, 2023
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This pull request's for a specific issue, related to Windows and the linked GitHub issue. I'll change the title so it's not misleading, but yeah, we'll eventually had 26.0 to the tests. Pretty sure you can already use it when consuming the action, though. Are you experiencing any issues?

@aboroska
Copy link

Our GH actions are failing with:
Error: Requested Elixir / Erlang/OTP version (1.14.4 / 26.0) not found in version list (did you check Compatibility between Elixir and Erlang/OTP?)

Screenshot 2023-05-17 at 11 52 35

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I see. That compatibility is not maintained by the action, though. It just reports on it.

OTP-26.0 is available from Hex.pm builds, for Ubuntu-20.04: https://builds.hex.pm/builds/otp/ubuntu-20.04/builds.txt

Elixir 1.14.4 for OTP-26 is also available from Hex.pm builds: https://builds.hex.pm/builds/elixir/builds.txt

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Works for me: https://github.com/paulo-ferraz-oliveira/setup-beam-example/actions/runs/5002581961/jobs/8962708174#step:3:26. It is possible, though, we're using different builds.txt files, as these are cached on Hex.pm.

@paulo-ferraz-oliveira paulo-ferraz-oliveira removed the help wanted Extra attention is needed label May 23, 2023
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separate cmd and args everywhere to make it easier to spot.

I also separate options to its own variable for similar reasons (and because I wanted to experiment with the differences between Linux and Windows)...

I add a few new debugging options for our own future comfort.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Now that the action is reported to work on top of Elixir 1.14.5 for Windows, I'm moving this away from draft (hopefully the tests will also show it working properly).

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review May 23, 2023 09:54
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Force pushed to resolve conflict. This'll probably not move the feature further than that, though.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Have Erlang/OTP 26 + Elixir 1.14 be usable in Windows Test Erlang/OTP 26 + Elixir 1.14 on top Windows Jun 23, 2023
Copy link
Member

@starbelly starbelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@starbelly starbelly merged commit 145c80c into erlef:main Jun 24, 2023
64 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/otp-26-on-windows branch June 24, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir installation on OTP26 hangs on Windows
3 participants