Apply stricter linting #24
Conversation
| @@ -133,15 +133,15 @@ async function getElixirVersion(exSpec0, otpVersion) { | |||
| `Requested Elixir version (from spec ${exSpec0}) not found in build listing`, | |||
| ) | |||
| } | |||
| const otpMatch = otpVersion.match(/^(?:OTP-)?([^\.]+)/) | |||
| const otpMatch = otpVersion.match(/^(?:OTP-)?([^.]+)/) | |||
There was a problem hiding this comment.
Not a real problem, but not visible with the previous linting procedure, either.
| @@ -179,8 +179,7 @@ async function getOTPVersions(osVersion) { | |||
| otpVersionsListing | |||
| .trim() | |||
| .split('\n') | |||
| .map((line) => { | |||
| debugger | |||
There was a problem hiding this comment.
Not a real problem, but not visible with the previous linting procedure, either.
| @@ -179,14 +179,12 @@ async function getOTPVersions(osVersion) { | |||
| otpVersionsListing | |||
| .trim() | |||
| .split('\n') | |||
| .map((line) => { | |||
| debugger | |||
| .forEach((line) => { | |||
There was a problem hiding this comment.
.map not really required
| const otpMatch = line.match(/^(OTP-)?([^ ]+)/) | ||
|
|
||
| const otpVersion = otpMatch[2] | ||
| otpVersions.set(otpVersion, otpMatch[0]) // we keep the original for later reference | ||
| }) | ||
| .sort() |
There was a problem hiding this comment.
.sort not really doing anything (apart from crashing if we use .forEach)
|
I'm still getting the following messages: " in the above box |
|
I'm not sure this is what's preventing me from merging. |
|
@paulo-ferraz-oliveira yes, this would prevent merging. I'd rather not disable it, but if this is going to be a consistent problem 🤔 The question is why? Why is it not running? |
These were renamed/removed, but apparently GitHub doesn't know about it 😄. |
|
I see the issue... |
|
@paulo-ferraz-oliveira so the issue was these outdated / no longer existent checks were still marked as required per our branch rules. Believe everything is up to date now. If you do a force push we can make sure that is so. Edit: @paulo-ferraz-oliveira force push not required, they are re-running now. |
|
What's annoying is github adds every single test in the pre-release integration matrix as an individual status check. I have temporarily unchecked all those and will revisit after this is merged. Rationale is it's not easy to decipher some of the old status checks from the new. |
So, after the previous experience with #9 I thought we could further restrict the JavaScript code by making for stricter linting. This pull request presents that.
How it rolled:
googletoairbnb(https://github.com/erlef/setup-beam/actions/runs/702116828)(this actually came from a comment by Eric where he asked if
return awaitwas OK - I thought "if it isn't there's probably some linting, out there, that'll help us further")