Accelerate application discovery #101
Conversation
|
I wonder if this should be the default behaviour then. Given a few recent issues/pull requests that might make sense. What do you think @tsloughter ? |
Introduce option `enable_shallow_app_discovery` which is disabled by default. When enabled searching for `*.app` files is done by using `filelib:wildcard/1` and doesn't recursively traverse all directories under `libs_dir` root dirs. Instead its assumed that each directory on `libs_dir` list contains a flat list of application dirs or is an app itself.
|
@ericbmerritt I just noticed that this PR failed on Travis. I have an amended version that passes dialyzer now. Do you want me to reopen this PR? |
|
@konradkaplita closing it was a mistake on my part (hit the wrong button). Please repush your changes. |
|
@ericbmerritt amended my pull request and Travis build is passing now, merge at will. Cheers! |
|
@ericbmerritt and this one? |
|
@tsloughter I will take a look at this again tonight. I remember thinking something about this and I need to recapture that thought. |
|
@ericbmerritt any update? |
|
not yet. I have just not had any time :( On Wed, Jan 22, 2014 at 12:43 PM, Tristan Sloughter <
|
|
I am creating a cross platform release using relx and I want relx to include erts by default but it should pick the cross compiled erts. I have provided the cross compiled erlang system library path using --system_libs, but relx pics the erts from the host system. How do I tell relx to pick the erts from a specified location. |
|
@ericbmerritt you ok to accept this now? |
Accelerate application discovery
Introduce option
enable_shallow_app_discoverywhich is disabled by default.When enabled, searching for
*.appfiles is done by usingfilelib:wildcard/1and it doesn't recursively traverse all directories underlibs_dirroot dirs.Instead its assumed that each directory on
libs_dirlist contains a flat list of application dirs or is an app itself.This pull request should solve #24 and together with #96 gives a lot faster build times which is especially helpful with big number of dependencies.
Our codebase currently has over 70 deps and we were able to reduce release generation times from 25 to 5 seconds.