Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'semver' placeholder in release defs with git derived vsn #201

Merged
merged 1 commit into from Jun 25, 2014

Conversation

tsloughter
Copy link
Member

This does NOT rely on my change to ec_git_vsn, so can be merged now if people agree with the change.

@tsloughter
Copy link
Member Author

@ericbmerritt thoughts?

@ericbmerritt
Copy link
Member

I like this and it looks reasonable. We should maybe make a warning about release upgrades not working if you use this though. Either in the readme or in the output

@tsloughter
Copy link
Member Author

Why would upgrades not work?

@ericbmerritt
Copy link
Member

If I remember correctly relx expects you to have multiple releases
configured in the config, and uses that to do the upgrade. However, I might
be misremembering.

On Tue, Jun 24, 2014 at 2:21 PM, Tristan Sloughter <notifications@github.com

wrote:

Why would upgrades not work?


Reply to this email directly or view it on GitHub
#201 (comment).

@tsloughter
Copy link
Member Author

Oh, na. By default it looks for a matching release in the path. So if you were on tag v1.0.0 and build that release, then switch to tag v1.1.0 and run relx relup it will build a relup from v1.0.0 to v1.1.0 -- this assuming you don't delete the first release from your path.

@ericbmerritt
Copy link
Member

Ok. no worries then.

On Tue, Jun 24, 2014 at 2:25 PM, Tristan Sloughter <notifications@github.com

wrote:

Oh, na. By default it looks for a matching release in the path. So if you
were on tag v1.0.0 and build that release, then switch to tag v1.1.0 and
run relx relup it will build a relup from v1.0.0 to v1.1.0 -- this
assuming you don't delete the first release from your path.


Reply to this email directly or view it on GitHub
#201 (comment).

jwilberding added a commit that referenced this pull request Jun 25, 2014
replace 'semver' placeholder in release defs with git derived vsn
@jwilberding jwilberding merged commit f9fc157 into erlware:master Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants