include vm.args or vm.args.src by default if they exist #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
approved these changes
Dec 1, 2020
tsloughter
force-pushed
the
auto-vm-args-src
branch
2 times, most recently
from
b7fcfec
to
7b1427a
Compare
tsloughter
force-pushed
the
auto-vm-args-src
branch
from
7b1427a
to
4651252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some ugly code in assemble but at least there are tests now so I feel safer when I go back and refactor -- as well as adding additional tests to cover all the possible combinations of the configs.