Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upgrade test #907

Merged
merged 1 commit into from May 18, 2022
Merged

add upgrade test #907

merged 1 commit into from May 18, 2022

Conversation

sg2342
Copy link
Contributor

@sg2342 sg2342 commented Feb 25, 2022

  • this regression test reproduces Application hot upgrade failed erlang/rebar3#2558
  • the test will succeed when keep attributes when stripping beams #906 is applied and fail otherwise
  • while there make shelltest/run_test.sh also work on platforms where sed(1) is of the BSD/MacOS variant (BSD/MacOS sed does not work with a bare -i flag and GNU sed does not work with -i '' so using a backup for the in-place edit and remove it afterwards is the least painful solution that works for both)

@tsloughter tsloughter merged commit 2b40a69 into erlware:main May 18, 2022
@sg2342 sg2342 deleted the upgrade_test branch May 18, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants