Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support modifiable query parts #7

Merged
merged 2 commits into from Jun 25, 2013
Merged

support modifiable query parts #7

merged 2 commits into from Jun 25, 2013

Conversation

ericbmerritt
Copy link
Member

No description provided.

@jwilberding
Copy link
Member

On two different boxes:

diginux@heisenberg ~/c/uri (master) [2]> make get-deps
/home/diginux/code/devenv-bootstrap/bin/rebar get-deps compile
==> rebar_vsn_plugin (get-deps)
==> uri (get-deps)
==> rebar_vsn_plugin (compile)
==> rebar_vsn_plugin (post_compile)
==> uri (compile)
src/uri.erl:37: syntax error before: '/'
src/uri.erl:94: syntax error before: '='
src/uri.erl:168: syntax error before: 'query'
src/uri.erl:212: syntax error before: 'query'
src/uri.erl:385: syntax error before: 'query'
src/uri.erl:391: syntax error before: 'query'
src/uri.erl:394: syntax error before: 'query'
src/uri.erl:395: syntax error before: 'query'
src/uri.erl:399: syntax error before: 'query'
src/uri.erl:400: syntax error before: 'query'
src/uri.erl:513: syntax error before: 'query'
src/uri.erl:728: syntax error before: '('
src/uri.erl:105: record uri undefined
src/uri.erl:127: function new/8 undefined
src/uri.erl:132: record uri undefined
src/uri.erl:133: variable 'Raw' is unbound
src/uri.erl:150: function new/8 undefined
src/uri.erl:156: spec for undefined function uri:new/8
src/uri.erl:192: function query_foldl/3 undefined
src/uri.erl:202: function query_foldl/3 undefined
src/uri.erl:210: spec for undefined function uri:query_foldl/3
src/uri.erl:331: record uri undefined
src/uri.erl:332: variable 'Scheme' is unbound
src/uri.erl:337: record uri undefined
src/uri.erl:341: record uri undefined
src/uri.erl:342: variable 'UserInfo' is unbound
src/uri.erl:347: record uri undefined
src/uri.erl:351: record uri undefined
src/uri.erl:352: variable 'Host' is unbound
src/uri.erl:357: record uri undefined
src/uri.erl:361: record uri undefined
src/uri.erl:362: variable 'Port' is unbound
src/uri.erl:367: record uri undefined
src/uri.erl:371: record uri undefined
src/uri.erl:372: variable 'Path' is unbound
src/uri.erl:377: record uri undefined
src/uri.erl:380: record uri undefined
src/uri.erl:381: variable 'Path' is unbound
src/uri.erl:384: spec for undefined function uri:raw_query/1
src/uri.erl:389: spec for undefined function uri:raw_query/2
src/uri.erl:406: record uri undefined
src/uri.erl:407: variable 'Frag' is unbound
src/uri.erl:412: record uri undefined
src/uri.erl:416: record uri undefined
src/uri.erl:417: variable 'Raw' is unbound
src/uri.erl:497: record uri undefined
src/uri.erl:499: record uri undefined
src/uri.erl:500: variable 'UserInfo' is unbound
src/uri.erl:502: record uri undefined
src/uri.erl:504: record uri undefined
src/uri.erl:505: variable 'Port' is unbound
src/uri.erl:508: record uri undefined
src/uri.erl:510: record uri undefined
src/uri.erl:511: variable 'Path' is unbound
src/uri.erl:522: record uri undefined
src/uri.erl:524: record uri undefined
src/uri.erl:525: variable 'Frag' is unbound
src/uri.erl:654: record uri undefined
src/uri.erl:657: record uri undefined
src/uri.erl:657: record uri undefined
src/uri.erl:658: function query_to_string/1 undefined
src/uri.erl:336: variable 'NewScheme' is unused
src/uri.erl:346: variable 'NewUserInfo' is unused
src/uri.erl:356: variable 'NewHost' is unused
src/uri.erl:366: variable 'NewPort' is unused
src/uri.erl:376: variable 'NewPath' is unused
src/uri.erl:411: variable 'NewFrag' is unused
ERROR: compile failed while processing /home/diginux/code/uri: rebar_abort
make: *** [get-deps] Error 1

@ericbmerritt
Copy link
Member Author

That's really strange. It compiles for me but dialyzer hangs let me look
into it

Sent from my iPhone

On Jun 24, 2013, at 11:06, Jordan Wilberding notifications@github.com
wrote:

On two different boxes:

diginux@heisenberg ~/c/uri (master) [2]> make get-deps
/home/diginux/code/devenv-bootstrap/bin/rebar get-deps compile
==> rebar_vsn_plugin (get-deps)
==> uri (get-deps)
==> rebar_vsn_plugin (compile)
==> rebar_vsn_plugin (post_compile)
==> uri (compile)
src/uri.erl:37: syntax error before: '/'
src/uri.erl:94: syntax error before: '='
src/uri.erl:168: syntax error before: 'query'
src/uri.erl:212: syntax error before: 'query'
src/uri.erl:385: syntax error before: 'query'
src/uri.erl:391: syntax error before: 'query'
src/uri.erl:394: syntax error before: 'query'
src/uri.erl:395: syntax error before: 'query'
src/uri.erl:399: syntax error before: 'query'
src/uri.erl:400: syntax error before: 'query'
src/uri.erl:513: syntax error before: 'query'
src/uri.erl:728: syntax error before: '('
src/uri.erl:105: record uri undefined
src/uri.erl:127: function new/8 undefined
src/uri.erl:132: record uri undefined
src/uri.erl:133: variable 'Raw' is unbound
src/uri.erl:150: function new/8 undefined
src/uri.erl:156: spec for undefined function uri:new/8
src/uri.erl:192: function query_foldl/3 undefined
src/uri.erl:202: function query_foldl/3 undefined
src/uri.erl:210: spec for undefined function uri:query_foldl/3
src/uri.erl:331: record uri undefined
src/uri.erl:332: variable 'Scheme' is unbound
src/uri.erl:337: record uri undefined
src/uri.erl:341: record uri undefined
src/uri.erl:342: variable 'UserInfo' is unbound
src/uri.erl:347: record uri undefined
src/uri.erl:351: record uri undefined
src/uri.erl:352: variable 'Host' is unbound
src/uri.erl:357: record uri undefined
src/uri.erl:361: record uri undefined
src/uri.erl:362: variable 'Port' is unbound
src/uri.erl:367: record uri undefined
src/uri.erl:371: record uri undefined
src/uri.erl:372: variable 'Path' is unbound
src/uri.erl:377: record uri undefined
src/uri.erl:380: record uri undefined
src/uri.erl:381: variable 'Path' is unbound
src/uri.erl:384: spec for undefined function uri:raw_query/1
src/uri.erl:389: spec for undefined function uri:raw_query/2
src/uri.erl:406: record uri undefined
src/uri.erl:407: variable 'Frag' is unbound
src/uri.erl:412: record uri undefined
src/uri.erl:416: record uri undefined
src/uri.erl:417: variable 'Raw' is unbound
src/uri.erl:497: record uri undefined
src/uri.erl:499: record uri undefined
src/uri.erl:500: variable 'UserInfo' is unbound
src/uri.erl:502: record uri undefined
src/uri.erl:504: record uri undefined
src/uri.erl:505: variable 'Port' is unbound
src/uri.erl:508: record uri undefined
src/uri.erl:510: record uri undefined
src/uri.erl:511: variable 'Path' is unbound
src/uri.erl:522: record uri undefined
src/uri.erl:524: record uri undefined
src/uri.erl:525: variable 'Frag' is unbound
src/uri.erl:654: record uri undefined
src/uri.erl:657: record uri undefined
src/uri.erl:657: record uri undefined
src/uri.erl:658: function query_to_string/1 undefined
src/uri.erl:336: variable 'NewScheme' is unused
src/uri.erl:346: variable 'NewUserInfo' is unused
src/uri.erl:356: variable 'NewHost' is unused
src/uri.erl:366: variable 'NewPort' is unused
src/uri.erl:376: variable 'NewPath' is unused
src/uri.erl:411: variable 'NewFrag' is unused
ERROR: compile failed while processing /home/diginux/code/uri: rebar_abort
make: *** [get-deps] Error 1

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/7#issuecomment-19924576
.

@ericbmerritt
Copy link
Member Author

@jwilberding all done and should work.

@jwilberding
Copy link
Member

Compiles and passes tests, but you have doc errors:

./src/uri.erl, function from_string/1: at line 107: multiple @doc tag.
edoc: skipping source file './src/uri.erl': {'EXIT',error}.
edoc: error in doclet 'edoc_doclet': {'EXIT',error}.
ERROR: doc failed while processing /Users/jwilberding/code/uri: {'EXIT',error}
make: [doc] Error 1 (ignored)
/Users/jwilberding/code/devenv-bootstrap/bin/rebar skip_deps=true eunit

@ericbmerritt
Copy link
Member Author

I know about the sic errors they have been there since the very beginning.
That is I did not introduce this errors they have just not been fixed

Sent from my iPhone

On Jun 25, 2013, at 1:58, Jordan Wilberding notifications@github.com
wrote:

Compiles and passes tests, but you have doc errors:

./src/uri.erl, function from_string/1: at line 107: multiple
@dochttps://github.com/doctag.
edoc: skipping source file './src/uri.erl': {'EXIT',error}.
edoc: error in doclet 'edoc_doclet': {'EXIT',error}.
ERROR: doc failed while processing /Users/jwilberding/code/uri:
{'EXIT',error}
make: [doc] Error 1 (ignored)
/Users/jwilberding/code/devenv-bootstrap/bin/rebar skip_deps=true eunit

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/7#issuecomment-19961653
.

jwilberding added a commit that referenced this pull request Jun 25, 2013
@jwilberding
Merge pull request #7 from ericbmerritt/master
a9543ee 
support modifiable query parts
@jwilberding jwilberding merged commit a9543ee into erlware:master Jun 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericbmerritt @jwilberding