Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaws_api:filter_parse/3 bug #324

Closed
leoliu opened this issue Mar 19, 2018 · 2 comments
Closed

yaws_api:filter_parse/3 bug #324

leoliu opened this issue Mar 19, 2018 · 2 comments

Comments

@leoliu
Copy link
Contributor

leoliu commented Mar 19, 2018

The function says return a list of values but erroneously return a tuple. Could someone take a look and also consider if returning {ok, Vs} is better than Vs? Thanks.

@vinoski
Copy link
Collaborator

vinoski commented Mar 19, 2018

Clearly, the code returns either a tuple or undefined, and this has been true for a long time — I traced the list_to_tuple call back over a decade, and the comment and the list_to_tuple call have been there together for quite awhile. Changing the return value now would likely break user code, so I won't change that, but I'll change the comment.

@leoliu
Copy link
Contributor Author

leoliu commented Mar 19, 2018

Thanks for the clarification.

Come to think about it more returning a list here would make it indistinguishable to single value.

vladdu pushed a commit to vladdu/yaws that referenced this issue Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants