Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
escapejs
filter to return binary, when it received binary as input.Couple of weeks ago I proposed to use
unicode:characters_to_list
inescapejs
to fix a bugwith handling 'line separator' and 'paragraph separator'.
Even, when it got binary as input,
escapejs
returned list as output,so I left it that way, but I believe, it should return binary, when it receives binary.
For example
first
filter works this way.