Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Retriable #4

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Retriable #4

wants to merge 8 commits into from

Conversation

ermaker
Copy link
Owner

@ermaker ermaker commented Aug 10, 2016

No description provided.

houndci-bot
houndci-bot reviewed Aug 10, 2016
View reviewed changes
lib/cool/retriable.rb
rescue on
next
end
return retval unless condition.call(retval)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use yield instead of condition.call.

@coveralls
Copy link

coveralls commented Aug 10, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 012cdee on retriable into a827119 on master.

@coveralls
Copy link

coveralls commented Aug 10, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 97dfce2 on retriable into a827119 on master.

@coveralls
Copy link

coveralls commented Aug 10, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f531e47 on retriable into a827119 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8b87830 on retriable into a827119 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ermaker @coveralls @houndci-bot