Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Moving dependencies to external file so that it is not packed with the code #693

Closed
Rafi993 opened this issue Oct 5, 2017 · 1 comment
Closed

Comments

@Rafi993
Copy link

Rafi993 commented Oct 5, 2017

Shout source repo is also packed with external dependency like Jquery, Moment etc.. wouldn't it be good if these dependencies are just installed via npm and then built using grunt so that they don't need to be pushed with the source repo.

@astorije
Copy link
Collaborator

astorije commented Oct 5, 2017

Hi @Rafi993!

You probably noticed that development of Shout has stalled. If you take a look at this section of the README, you'll notice that active development has moved to The Lounge.

And your suggestion makes so much sense that it was in fact done there: thelounge/thelounge#817
Difference is that we use Webpack + npm scripts instead of Grunt now, but yeah, everything is built off npm now :)

👋

@Rafi993 Rafi993 closed this as completed Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants