This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add socket.io transports to configuration #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Merging! |
erming
added a commit
that referenced
this pull request
Nov 5, 2014
Add socket.io transports to configuration
|
Okay, thought I might as well tell you: I just found an error. A missing |
|
Oh damn, sorry about that. Would be nice to have a couple of tests to catch mistakes like this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wan't to install shout, but I can't since it's not possible for me to proxy websocket-traffic through Apache.
Therefore I added a new configurable option for defining which transports socket.io is allowed to use and managed to get everything up and running.