#268 : show seconds in interface

[ruliane]

Time format modified : seconds are displayed

[astorije]

I have mixed feelings about this. On one hand, I am happy that the client doesn't show second or else I (and my copy-paste) would have cognitive overflow. On the other hand, I understand some people want/need seconds to show.

I'd much prefer the original proposal: possibility to choose user-wide settings for this. Better would even be a checkbox saying "Display seconds" rather than specifying the format, much more accessible to non-tech savvy folks. Plus it's safer as there is no potential injection to prevent from.

@ruliane, would you mind adding such configuration in the User Settings?

[floogulinc]

@astorije I was thinking about doing that for Shuo. I can work on adding it to the settings, I have some experience there from adding theme support.

[astorije]

Nice @floogulinc! (Note that I added a similar comment on the related issue)

I'd be grateful if you did it here in the parent project, hoping that @erming is going to open his baby to the community a bit...

[JocelynDelalande]

I'd much prefer the original proposal: possibility to choose user-wide settings for this. Better would even be a checkbox saying "Display seconds" rather than specifying the format, much more accessible to non-tech savvy folks. Plus it's safer as there is no potential injection to prevent from.

+1 for this proposal

[astorije]

Which one, a text field with "HH:mm" in it or a checkbox to display seconds? (and a later one to support 12/24h format if that's a desired feature, etc.)

I'd definitely go for the latter!

[floogulinc]

@astorije The latter is what I plan on doing.

[ruliane]

A "Display seconds" checkbox would probably be the best, but to answer @astorije 's question: I have no idea how to implementing such a thing. :( I simply add the patch suggested in issue #268.

[JocelynDelalande]

@ruliane you mean that you have no js dev skills ?

[ruliane]

That's it. (I'm not a dev, js nor anything else. ;) )

[JocelynDelalande]

@ruliane ok (never too late to learn ;-))

So, sadly, I suggest closing this PR, as the solution is more a personal hack than a nicely packaged feature.

… Till someone comes with another PR with the checkbox thing :-)

[floogulinc]

@JocelynDelalande That's what im working on right now 😄

[astorije]

@floogulinc Good, we all agree then. Let me know if you need any help or if you have any questions, here or on the #shout-irc channel where I have installed a comfy tent.

@ruliane, it's OK, it's already very nice of you to offer your contribution. Whether we accept it, comment on it, or close it for justified reasons, we (the community) always appreciate that. Keep going and feel free to ask questions on the IRC channel!

@JocelynDelalande, I agree, and that future PR should also link here. At the moment only @erming and @ruliane can close this PR, @ruliane do you mind closing it? I don't think we'll hear from @erming right away :-)

[ruliane]

Looking forward to a better PR. :)