-
Notifications
You must be signed in to change notification settings - Fork 273
Add show timestamp toggle #484
base: master
Are you sure you want to change the base?
Conversation
Nice addition @floogulinc, thanks! However, I notice that, on mobile (the smallest version), Shout by defaults hides the timestamp. With your PR, that makes your checkbox appear non working there. I see 2 possible fixes:
I personally prefer the first solution. Not only it's what I expect on mobile by default (plus it's consistent with other sizes and we can probably merge 2 width categories), but it's also much simpler in code. Solution 2 forces you to check the width of the screen using JS, ... urgh. What do you think? |
@astorije You can remove timestamps from mobile by removing #chat .time {
display: none;
} from the I honestly don't know if there is enough room on mobile (phones specifically) to do timestamps, at least not in the same way we have them everywhere else. |
Urgh, 2 lines are ugly. @floogulinc, I am not sure we can make this decision here: some mobiles have gigantic screens, some don't. And fashion goes to increase your screen size as you upgrade your phone, sadly... My proposal still holds: let's show timestamp by default (first solution) and use your checkbox to please those who would like more room. At the moment, mobile users cannot even display the timestamp, which is very annoying. Your PR will let them (us!) do so while easily switching to no timestamp again. Thanks! I honestly can't wait for this PR to make it live! |
@astorije Just note that that the screenshot is from a 6 inch 1440p phone. So it seems pretty ugly on any phone in portrait, If i rotate it then it switches to "tablet" view and works fine with the timestamps. |
+1 again for this. I often miss the timestamps and and have to rotate my device to see them. Kind of sucks. I thinks it would be fine even if the nicks won't line up vertically. I would love this feature! |
@floogulinc, I'm not sure about your meaning, are you agreeing with me? Actually, @richrd has a good point, we do not need to have the timestamps line up on mobile. I think the best result would be to have on mobile So in a nutshell, here is my final offer:
|
@floogulinc, any updates on this? :-) |
@floogulinc, could you make the small change I suggested so that this can go live? It really is a shame we could not finalize this earlier, but I hope we can still do it :-) |
Closes #93