Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Turn back on input autocomplete #518

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

floogulinc
Copy link
Collaborator

Now you can type well on mobile!

See Shuo-IRC/Shuo#88

This reverts commit d5fe68b.

@astorije astorije self-assigned this Oct 13, 2015
@astorije
Copy link
Collaborator

Typing well on my mobile, amen to that!! I was fed up with blindly swiping :-)
Thanks a lot @floogulinc!

More information for the curious: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

That's a 👍 for me, awaiting for second review as per our peer review policy.

@JocelynDelalande
Copy link
Collaborator

👍 for me.

@JocelynDelalande
Copy link
Collaborator

Thanks @floogulinc

JocelynDelalande added a commit that referenced this pull request Oct 15, 2015
@JocelynDelalande JocelynDelalande merged commit f4a6f46 into erming:master Oct 15, 2015
@sc0tt
Copy link

sc0tt commented Nov 4, 2015

Can this at least be made a preference? It's very annoying with chrome when I focus the text box.

@astorije
Copy link
Collaborator

astorije commented Nov 4, 2015

@sc0tt, this is not desirable, as it fixes a bug. However, I agree with you that the current solution is not ideal. This is due to the fact that autocomplete seems to affect 2 things:

  • proposing previous texts entered by the user
  • offering typing assistance / autocorrect suggestions

While the first one should be disabled, the second one is a mandatory accessibility component. For example, Android features such as "swiping" a text are totally unusable without it.

If you feel like tackling this, PRs are most welcome. As an example, I noticed that the chat on Facebook, in Android's browser, reacts as expected (no history suggestions, but autocorrect suggestions are on), if one wants to study how they do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants