Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Update dependancies #611

Closed
wants to merge 1 commit into from
Closed

Update dependancies #611

wants to merge 1 commit into from

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Jan 24, 2016

I hope I didn't miss any breaking changes. Couldn't update socket.io as it kept complaining about parse error.

"mkdirp": "^0.5.0",
"moment": "~2.7.0",
"moment": "~2.11.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the dependencies you updated, let's use the non tilde-range (~) version: cheerio in 0.19.0 instead of ~0.19.0, ...

Having tilde-ranges gives you the false impression you stay latest why this cannot be ensured. I've noticed that projects reaching a decent size switch to the fixed versions as well. Let's do that as we upgrade dependencies :-)

@astorije
Copy link
Collaborator

Hey @xPaw, thanks for this! Don't you think we should have one PR per upgraded prod dependency (and an additional one for all devDependencies)?
I believe it would be easier to review, to test and to potentially debug :-)

@AlMcKinlay
Copy link
Contributor

@astorije I would agree for breaking changes. I think it's fine to keep everything else in the same one, but let's keep lodash in a different PR as it's such a big jump. We can test it for a bit and make sure nothing else has gone wrong. I might have time sometime later this week to also read through the breaking changes.

@xPaw Did you remember to check both the 3.x and the 4.x breaking changes for lodash?

@xPaw
Copy link
Contributor Author

xPaw commented Jan 24, 2016

@YaManicKill I did, yes.

@astorije
Copy link
Collaborator

I agree with @YaManicKill. @xPaw, do you mind opening a PR just for lodash? :)

@xPaw
Copy link
Contributor Author

xPaw commented Jan 24, 2016

This PR now only upgrades cheerio and moment, and drops ^ ~ from versions

@williamboman
Copy link
Contributor

drops ^ ~ from versions

Wouldn't it be better to bump versions to the latest version within the current semver range as well? This PR effectively downgrades most deps.

@astorije
Copy link
Collaborator

@williamboman, the transition is awkward for sure, but it's the safest way to go on long-term.

@xPaw, what about removing ~/^-ranges as we upgrade the versions, and keep these to the packages we haven't upgraded yet, unless this is already the latest version? I feel it's a good compromise.

@astorije astorije self-assigned this Jan 27, 2016
@xPaw
Copy link
Contributor Author

xPaw commented Jan 27, 2016

You're right about versions, I've upgraded them. Left out lodash as there's a separate PR, and socket.io because it breaks, and the client lib needs updating too.

@AlMcKinlay
Copy link
Contributor

Oh? What breaks about socket.io? I did a quick upgrade of it sometime past and didn't notice anything, but I didn't look at everything, and didn't look at the release notes for breaking changes.

I'll add a ticket for that specifically, because it'd be good to upgrade that as there are a number of issues with the version we are currently on.

@xPaw
Copy link
Contributor Author

xPaw commented Jan 27, 2016

The page kept reloading for me due to a decoding error.

@AlMcKinlay AlMcKinlay mentioned this pull request Jan 27, 2016
@MaxLeiter
Copy link
Contributor

Discussion on updating client libs is here just in case people cant find it: #562

@xPaw
Copy link
Contributor Author

xPaw commented Feb 12, 2016

Closing in favor of thelounge/thelounge#8

@xPaw xPaw closed this Feb 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants