Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Initial work on context menus #613

Closed
wants to merge 5 commits into from
Closed

Initial work on context menus #613

wants to merge 5 commits into from

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Jan 24, 2016

chrome_2016-01-25_15-47-56

@MaxLeiter
Copy link
Contributor

Just adding my two cents: I think on mobile the context menu should exist elsewhere as a button, similar to the 'leave' one. Perhaps we can replace the current leave channel ('x') button with a dropdown arrow?

@xPaw
Copy link
Contributor Author

xPaw commented Jan 27, 2016

I would rather try to make long press work instead of adding arrows.

@AlMcKinlay
Copy link
Contributor

I agree with @xPaw

For a button to work, we would need to increase the size of the sidebar, as trying to hit a button on that small name is near impossible currently (it's hard enough to hit the expando for link expander just now as it is).

@MaxLeiter
Copy link
Contributor

If long press opens a context menu then how would mobile users rearrange channels and servers?

@xPaw
Copy link
Contributor Author

xPaw commented Jan 27, 2016

At least in Chrome on Android long press simply selects the text, you can't rearrange servers.

@xPaw
Copy link
Contributor Author

xPaw commented Jan 30, 2016

Figured out how to make the context menu work on mobiles, by adding user-select: none; on the sidebar.

photo_2016-01-30_23-13-13

@AlMcKinlay
Copy link
Contributor

I really like this so far, looks really nice and it brings forward many features to the user, especailyl on mobile.

I think having a longpress on mobile, and right-click on desktop works really nicely as these are things people expect to do something like that.

@MaxLeiter
Copy link
Contributor

I agree that longpress make sense on mobile, but I think there should be a way to reorganize channels and servers. That could be built into the context menu (ie “unlock” or “move down”) but that seems like an awkward UX choice

@AlMcKinlay
Copy link
Contributor

We could have a "grabber" (I forget what the proper word for them is) on touch-screen devices that you can use for reordering.

@xPaw
Copy link
Contributor Author

xPaw commented Jan 31, 2016

The question is why current grabbing stuff does't work on mobile. That should be triggered long before the contextmenu event.

EDIT: Shout is using sortable from jQuery UI, and that doesn't work with mobile events by default. Including https://github.com/furf/jquery-ui-touch-punch/ makes it work.

@xPaw
Copy link
Contributor Author

xPaw commented Feb 12, 2016

Closing this in favor of thelounge/thelounge#9

@xPaw xPaw closed this Feb 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants