Update chat template so no users-icon shown when a server or private conversation is selected. #623
Conversation
MaxLeiter
changed the title
|
👍
Nah. Channels eventually should have settings too. |
|
Definitely don't add a settings icon yet. However, yeah, I don't think you should set this up as if the settings is only going to be on the lobby. I would just show user on anything other than lobby or user. |
|
Thats how it works with his PR @YaManicKill |
Definitely not, or we'll have a lot of "Settings don't work" issues popping up :-) This is an off-topic side note that we should keep for later (the user settings design doc I was mentioning in #604), but I'm concerned about UI/UX regarding having a Settings button at the bottom left of the app (for global settings) and on the top right of each channel (for channel settings). I have ideas about that and will share them. |
| {{!-- Insert settings icon --}} | ||
| {{else}} | ||
| <button class="rt"></button> | ||
| {{/equal}} |
There was a problem hiding this comment.
I'm very not fond of placeholders like this one for potential future code/UI elements that might not be located there. Could you instead check that the type is not lobby then display the button, without else statement please?
There was a problem hiding this comment.
Actually, checking that the type is a channel is probably more appropriate to make sure it doesn't show up on lobbies and private messages. Anything else we should display or not display this?
There was a problem hiding this comment.
You're right, changing it to {{#equal type "channel"}} will do the job.
|
By the way, thanks a lot for that!! :-) |
Changes check to 'if channel' instead of 'if lobby else'
|
@MaxLeiter, just to confirm, is |
|
I forgot to run it a second time; will update tonight and message in IRC when I do. |
|
@astorije looks like I did update the template; ready to pull :) |
|
👍 |
MaxLeiter
changed the title
|
Worth noting that checking if its a channel also solved the issue of a user icon showing in private conversations. |
|
For the record, this was ported to The Lounge in PR thelounge/thelounge#32, appearing for the first time in v1.0.2. |
Fixes #622, should I add a font-awesome settings icon even if it won't do anything at the moment?