Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery 3.0 support: .length property instead of .size() #27

Closed
majorebola opened this issue Jul 27, 2016 · 2 comments
Closed

Jquery 3.0 support: .length property instead of .size() #27

majorebola opened this issue Jul 27, 2016 · 2 comments

Comments

@majorebola
Copy link

@majorebola majorebola commented Jul 27, 2016

Seems like JqueryMy uses .size() property.
But in jQuery 3.0 it has been removed (it was deprecated since 1.8)
https://api.jquery.com/size/

I simply tried removing (find-replace) $o.size() with $o.length and it seems to work.
But I'm not at all into jquerymy so I suppose we need more tests.

@ermouth
Copy link
Owner

@ermouth ermouth commented Jul 27, 2016

Good point. Will test approach for 2.x and if everything is ok, put it into 1.2.7.

Thank you.

ermouth added a commit that referenced this issue Jul 30, 2016
Applies proposal from #27
@ermouth
Copy link
Owner

@ermouth ermouth commented Jul 30, 2016

Applied.

@ermouth ermouth closed this Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.