Jquery 3.0 support: .length property instead of .size() #27

Closed
majorebola opened this Issue Jul 27, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@majorebola

Seems like JqueryMy uses .size() property.
But in jQuery 3.0 it has been removed (it was deprecated since 1.8)
https://api.jquery.com/size/

I simply tried removing (find-replace) $o.size() with $o.length and it seems to work.
But I'm not at all into jquerymy so I suppose we need more tests.

@ermouth

This comment has been minimized.

Show comment
Hide comment
@ermouth

ermouth Jul 27, 2016

Owner

Good point. Will test approach for 2.x and if everything is ok, put it into 1.2.7.

Thank you.

Owner

ermouth commented Jul 27, 2016

Good point. Will test approach for 2.x and if everything is ok, put it into 1.2.7.

Thank you.

ermouth added a commit that referenced this issue Jul 30, 2016

1.2.7
Applies proposal from #27
@ermouth

This comment has been minimized.

Show comment
Hide comment
@ermouth

ermouth Jul 30, 2016

Owner

Applied.

Owner

ermouth commented Jul 30, 2016

Applied.

@ermouth ermouth closed this Jul 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment