Fix linter warnings

ernado · May 20, 2019 · 9084442 · 9084442
1 parent 333db01
commit 9084442
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -16,3 +16,8 @@ issues:
   exclude-use-default: false
   max-per-linter: 0
   max-same-issues: 50
+
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - dupl
diff --git a/candidate.go b/candidate.go
@@ -146,7 +146,7 @@ func (c *Candidate) recvLoop() {
 			}
 			// Explicitly copy raw buffer so Message can own the memory.
 			copy(m.Raw, buffer[:n])
-			if err := m.Decode(); err != nil {
+			if err = m.Decode(); err != nil {
 				log.Warnf("Failed to handle decode ICE from %s to %s: %v", c.addr(), srcAddr, err)
 				continue
 			}

diff --git a/url.go b/url.go
@@ -155,13 +155,13 @@ func ParseURL(raw string) (*URL, error) {
 	switch {
 	case u.Scheme == SchemeTypeSTUN:
 		qArgs, err := url.ParseQuery(rawParts.RawQuery)
-		if err != nil || (err == nil && len(qArgs) > 0) {
+		if err != nil || len(qArgs) > 0 {
 			return nil, ErrSTUNQuery
 		}
 		u.Proto = ProtoTypeUDP
 	case u.Scheme == SchemeTypeSTUNS:
 		qArgs, err := url.ParseQuery(rawParts.RawQuery)
-		if err != nil || (err == nil && len(qArgs) > 0) {
+		if err != nil || len(qArgs) > 0 {
 			return nil, ErrSTUNQuery
 		}
 		u.Proto = ProtoTypeTCP