Add LimitNOFILE in prometheus.service #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thank you for contributing, I will fix CI in few days |
|
please rebase on master |
shimulch
force-pushed
the
shimulch/bb-3847
branch
from
b7710ac
to
0af3603
Compare
|
@ernestas-poskus, Thanks for fixing the CI. This PR is now rebased on master. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, our Prometheus service stopped scrapping. Upon investigation, we found that Prometheus was logging the following error repeatedly -
Setting
LimitNOFILEtoinfinityon theprometheus.servicesolved the issue for us. Since there is no way of setting that in this role, we've opened this PR.This PR also includes a new configuration variable
prometheus_service_limitnofilewhich can be used to set other values forLimitNOFILEother thaninfinity.